commit 8d338b5b659211915ecd35cb9a18a8b4cc5424c5 Author: Stephan Wiesand Date: Fri Mar 14 16:01:16 2014 +0100 Make OpenAFS 1.6.8pre2 prerelease for 1.6.8 Change-Id: I1664633e86e218330c729362d5814ec8c160fc5c Reviewed-on: http://gerrit.openafs.org/10894 Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand commit a983bca3ed7efc4c63d796c8440995531522324c Author: Benjamin Kaduk Date: Fri Jan 24 12:00:20 2014 -0500 FBSD: catch up to 1997 and include if_var.h with if.h The commit message for upstream's r257244 change includes: - Make the prophecy from 1997 happen and remove if_var.h inclusion from if.h. Despite the clear public posting, we were caught unawares. We made it down to the cellar despite the missing stairs, but "Beware of the Leopard" caused us to turn back, apparently. Since if.h is included in many places and if_var.h is not present on all OSes, pull the if.h inclusion into the common kernel headers for afs/ and rx/ , and add in if_var.h (as well as the sys/socket.h prerequisite). Reviewed-on: http://gerrit.openafs.org/10754 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 8817308a87ca76bc47a0f5564b97c7942b3be04a) Change-Id: I8a03c7b2a0fe54f987b6d63cac19980f66c80e9d Reviewed-on: http://gerrit.openafs.org/10987 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Stephan Wiesand commit dcf389d3ec3c84f4d07f8f9d98cb0835a9b72b28 Merge: 5fe7d84 94ffd11 Author: Stephan Wiesand Date: Wed Apr 9 14:10:35 2014 +0200 Merge branch '1.6-security' into HEAD Conflicts: NEWS configure-libafs.ac configure.ac src/config/NTMakefile.amd64_w2k src/config/NTMakefile.i386_nt40 src/config/NTMakefile.i386_w2k Change-Id: If4cf26d5559229a35b2754957f856350a8100ffb commit 94ffd115f0510fde86339395f88d41d9d56950f4 Author: Stephan Wiesand Date: Thu Apr 3 14:07:58 2014 +0200 Make OpenAFS 1.6.7 Update version strings for 1.6.7 Change-Id: Ia9d931cd5329afb440cfa7da1f139ae669c6e8ae commit ba73b9a766379fc56e6a1724c79b6e0c3cc85e62 Author: Stephan Wiesand Date: Thu Apr 3 13:54:58 2014 +0200 Update NEWS for 1.6.7 Release notes for OpenAFS 1.6.7. Change-Id: I9c331ca0dd01f9617917af326f58fc1944c152d7 commit cde152658dcf5ee31293ed75b9a6cfaf8192f320 Author: Michael Meffie Date: Sat Feb 15 12:03:43 2014 -0500 viced: fix get-statistics64 buffer overflow Range check the statsVersion argument of the GetStatisitics64 RPC to avoid a buffer overflow in the fileserver, or a huge memory allocation, by a rogue client. FIXES 131803 (cherry picked from commit bd2cc32da969abe57334d20563d5cddf065a905e) Change-Id: I05b18b9f4bacd8981eafb9fe4b5aea904f88a9cc commit 19c4d6023c8f616de0d194e560e64576e5986f70 Author: Andrew Deason Date: Fri Feb 21 15:30:49 2014 -0600 rx: Avoid rxi_Delay on RXS_CheckResponse failure Currently we rxi_Delay whenever RXS_CheckResponse fails for any reason. This can result in disastrous performance degradations if a client keeps sending "bad" responses, since rxi_Delay'ing here will delay the Rx listener thread. This means we cannot receive any packets for about a second, which can easily cause us to drop a lot of incoming packets. Instead, send the abort after 1 second by scheduling an event. This will retain existing behavior from the point of view of the client (it will get the abort after 1 second), but avoids hanging the Rx listener thread. FIXES 131802 (cherry picked from commit 0ec67b0a9a175af14e360da75d1f5429c6c97b24) Change-Id: Idf2fb2cc26c013b9071d578b46f6d4831ff3fe5f commit 32688c069f22f3b96e261f2361e251081957a047 Author: Andrew Deason Date: Fri Feb 21 15:26:35 2014 -0600 rx: Split out rxi_SendConnectionAbortLater Take the functionality in rxi_SendConnectionAbort that schedules a delayed abort, and split it out into a new function, rxi_SendConnectionAbortLater. This allows callers an easy interface to send such a delayed abort with their own delay. This commit should incur no change in behavior; it is just code reorganization. (cherry picked from commit 61d80537cae95d125c4b9fed31e2454a281b8b02) Change-Id: I8798ace952bffa0c736ab90e9028fd7c99305a78 commit 5fe7d847f274f90a1ff48a215308b43d3a23266c Author: Stephan Wiesand Date: Fri Mar 14 15:59:29 2014 +0100 Make OpenAFS 1.6.8pre1 prerelease for 1.6.8 Change-Id: I1b0632aa5b76ecff1690fb252eb3427aa17aaad0 Reviewed-on: http://gerrit.openafs.org/10893 Reviewed-by: D Brashear Reviewed-by: Jeffrey Altman Tested-by: Chas Williams - CONTRACTOR Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Stephan Wiesand commit b218854d406e7c4aab46aba437234f7254f8a9ce Author: Stephan Wiesand Date: Thu Mar 27 10:27:17 2014 +0100 Update NEWS for 1.6.8 release notes for OpenAFS 1.6.8 Change-Id: I77712d776a2c31eb2c65612768734a4cceaa1d34 Reviewed-on: http://gerrit.openafs.org/10958 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Stephan Wiesand commit e6a43bff17019160154726d7f6ed48805ae14cbc Author: Andrew Deason Date: Wed Feb 26 11:42:16 2014 -0600 viced: Restore some previous log message language Before commit 6c41b1f740e16b5b9adfe9026630595be6f0699e, we logged these three messages in the fileserver in different situations: CallPreamble: Couldn't get client. CallPreamble: Couldn't get CPS. Fail CallPreamble: couldn't reconnect to ptserver After commits 6c41b1f740e16b5b9adfe9026630595be6f0699e and 0a5e878aa0a71c4dfaef1806744ed78bcc13b9f4, these messages were changed to contain more useful information, but the language was also changed. The messages now look like: Client host too busy while handling request from host %s:%d viceid %d fid %lu.%lu.%lu, failing request Cannot get CPS for client while handling request [...], failing request Cannot reconnect to ptserver while handling request [...], failing request While the new messages are more informative, and (in my opinion) better describe what is happening in those situations, they do look very different from the old messages. This can break scripts that try to parse these logs, but in general it is also not clear to administrators that these messages still refer to the same events. So instead, put these messages back the way they were. Still include the extra information, of course, but revert the language to look more like the old messages. Now we log: CallPreamble: Couldn't get client while handling request from host %s:%d viceid %d fid %lu.%lu.%lu, failing request CallPreamble: Couldn't get CPS while handling request [...], failing request CallPreamble: couldn't reconnect to ptserver while handling request [...], failing request Thanks to Ben Kaduk for bringing this up. Reviewed-on: http://gerrit.openafs.org/10857 Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Tested-by: D Brashear Reviewed-by: D Brashear (cherry picked from commit 0e9bb718ce231ffd73fe11810d8dc1d3902e4b2d) Change-Id: I35c8369a7efba0c08c000a24e14385209082cfe0 Reviewed-on: http://gerrit.openafs.org/10953 Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Chas Williams - CONTRACTOR Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 462cc497db11c390e626925d383bdef9c98a1e62 Author: Andrew Deason Date: Thu Oct 17 20:22:48 2013 -0400 viced: Improve client error log messages Commit 6c41b1f740e16b5b9adfe9026630595be6f0699e improved a few log messages to include the client ip and port of the request triggering that log message. Include the viceid and fid (if applicable), too, so an administrator may more easily identify the cause. This creates the function LogClientError, so we can use a common function for logging very similar information. This also modifies h_FindClient_r to give the viceid to the caller, even in the case of error. In addition, this modifies CallPreamble to accept a fid and modifies all callers to accomodate. Reviewed-on: http://gerrit.openafs.org/10347 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 0a5e878aa0a71c4dfaef1806744ed78bcc13b9f4) Change-Id: Ib8b41989809e559dee486757b11ccff789d615e9 Reviewed-on: http://gerrit.openafs.org/10757 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit c4752dca439a12c2be162eb98869ef37d7c43767 Author: Stephan Wiesand Date: Wed Mar 12 10:47:17 2014 +0100 doc: bos setrestricted -mode 0 does make sense Commit 070230ab76e1df338db3f2a7971111ca976a0c1a added documentation of the mode parameter to bos setrestricted, claiming that the value 0 is useless, and commit eee0bf5871944d919951cc8b7b4908ee909c3b62 added documentation of the restrictmode entry in BosConfig, claiming that it can only be set back to 0 with an editor. Both claims are wrong, since bos setrestricted -mode 0 will do exactly that (if it succeeds, which it only can if the server is running in unrestricted mode, which can be achieved by sending it the FPE signal). Fix the man pages accordingly. Reviewed-on: http://gerrit.openafs.org/10885 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Marc Dionne Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: D Brashear (cherry picked from commit da549eea21941681c075796512a27a830259c835) Change-Id: Iea8f252829ba6192176da0ceba464cbc41aad53c Reviewed-on: http://gerrit.openafs.org/10955 Reviewed-by: Andrew Deason Tested-by: Stephan Wiesand Reviewed-by: Stephan Wiesand commit d138114092426ddda6ff78f380f1042994039dae Author: Andrew Deason Date: Fri Jun 14 15:58:45 2013 -0500 doc: bos manpage fixes Add missing documentation for the -mode option. Reviewed-on: http://gerrit.openafs.org/10390 Reviewed-by: Ken Dreyer Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 070230ab76e1df338db3f2a7971111ca976a0c1a) Change-Id: I0780fc350840631d55d60c21e6223020ca9a845f Reviewed-on: http://gerrit.openafs.org/10954 Reviewed-by: Andrew Deason Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand commit cbb2ce7fe1a297191336b2488c9f86cebab5f15d Author: Stephan Wiesand Date: Fri Mar 7 11:03:36 2014 +0100 doc: improve man pages related to bos restricted mode Mention the restrictmode entry and the commands for setting and querying it in the BosConfig man page, and add/fix cross references between the BosConfig, bos, bos_getrestricted and bos_setrestricted ones. Reviewed-on: http://gerrit.openafs.org/10874 Reviewed-by: Ken Dreyer Reviewed-by: Benjamin Kaduk Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit eee0bf5871944d919951cc8b7b4908ee909c3b62) Change-Id: I25d2f23d75a9074ae478f86296bb13c1b2dda95b Reviewed-on: http://gerrit.openafs.org/10883 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 395c04fbca7760979b7bc4e371c1f9f8e1d09858 Author: Michael Meffie Date: Fri Feb 7 06:55:31 2014 -0800 fs: display cell not available on ESRCH The cache manager pioctls abuse ESRCH to represent errors due to unavailable cell information. Give a more sensible error message to the user when a pioctl returns an ESRCH error, instead of "no such process", which is the conventional meaning of ESRCH. The new error message is consistent with the Windows implementation of fs. For example, on a host with a misconfigured ThisCell and/or CellServDB. $ fs wscell fs: No such process becomes: $ fs wscell fs: Cell name not recognized. Reviewed-on: http://gerrit.openafs.org/10824 Tested-by: BuildBot Reviewed-by: D Brashear (cherry picked from commit 8beba712d95b637225f215534a759961ff4d80a9) Change-Id: I0cf6f6e0939a1075332049361153bc8a0b0958ce Reviewed-on: http://gerrit.openafs.org/10949 Reviewed-by: D Brashear Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand commit 7726ef868c9afb0e5447cc4e49944f9dd8fa5738 Author: Stephan Wiesand Date: Fri Mar 14 17:51:49 2014 +0100 doc: fix releases mentioned in fileserver sync behavior documentation The default will likely change in 1.6.8, not 1.6.7. Change-Id: I5f5d62979fabd22ed79ccac6c584921acf571108 Reviewed-on: http://gerrit.openafs.org/10897 Reviewed-by: D Brashear Reviewed-by: Michael Meffie Tested-by: Stephan Wiesand commit f59acadef1f0278fe37f1ad2b07912a0308b2294 Author: Michael Meffie Date: Tue Mar 11 12:40:33 2014 -0400 libafs: reset global icl set pointers on shutdown Avoid panicking when an icl tracing function is called after shutdown_icl. There is a window during shutdown in which pioctls can be requested after the shutdown_icl is issued. Reset the global icl set pointers so tracing is disabled after the shutdown_icl, instead of using pointers to freed memory. Removed the unneeded afs_icl_FindSet calls and use the global pointers which were set during the initialization. Reviewed-on: http://gerrit.openafs.org/10884 Tested-by: BuildBot Reviewed-by: Marc Dionne Reviewed-by: Benjamin Kaduk Reviewed-by: D Brashear (cherry picked from commit 64dd6dd018eb7413636ed6416bd244bb81893d9e) Change-Id: I65671ee60e3cdf11d9921585dcd67df7cc22c88f Reviewed-on: http://gerrit.openafs.org/10932 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit c24dd7dc74e35cbc79b572eafe2fd47c9108c478 Author: Hartmut Reuter Date: Mon Mar 10 17:21:21 2014 +0100 volser: use also vn_length_hi in dump size calculation Only the low order 32 bits of the file length were used. Now using macro VNDISK_GET_LEN instead of direct FillInt64. FIXES 131819 Reviewed-on: http://gerrit.openafs.org/10876 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 705f3ee384814bc082817267a2658bd5c918550c) Change-Id: I1816e4b7c5fe1166ac81ff53235f9f676f4d234f Reviewed-on: http://gerrit.openafs.org/10933 Tested-by: BuildBot Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand commit 20217c278ef9ed554d4a53686fe867bca0007d3d Author: Marc Dionne Date: Wed Mar 19 11:15:13 2014 -0400 Linux: Do drop dentry if lookup returns ENOENT Commit 997f7fce437787a45ae0584beaae43affbd37cce switched to using d_invalidate instead of d_drop to prevent unhashing dentries which are only temporarily invalid and may still be referenced by someone having a current working directory pointing to it. This could result in getting ENOENT from getcwd() after some transient problems, even when the directory is there and accessible. The change had the side effect of potentially leaving something visible when it has actually been removed, for instance a mountpoint removed by "fs rm". If afs_lookup returns ENOENT, we want to forcibly drop (unhash) the dentry, even if it has current users. Reviewed-on: http://gerrit.openafs.org/10928 Tested-by: BuildBot Reviewed-by: D Brashear (cherry picked from commit 389473032cf0b200c2c39fd5ace108bdc05c9d97) Change-Id: Ifeda5a38a01bc136d3ecef01227ecd354da7cc3e Reviewed-on: http://gerrit.openafs.org/10948 Reviewed-by: D Brashear Tested-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit a23e76c6dcf0fc56df6d971bae2686003c6386fd Author: Benjamin Kaduk Date: Wed Mar 19 12:16:48 2014 -0400 Make struct CallBack indentation uniform again Align the per-field comments. Reviewed-on: http://gerrit.openafs.org/10929 Tested-by: BuildBot Reviewed-by: Stephan Wiesand Reviewed-by: Jeffrey Altman (cherry picked from commit cb4ec4e4952b40999013d4f67c0add6bf51ff286) Change-Id: I9b388d03d9ca3da10eba6010147427b44a88d787 Reviewed-on: http://gerrit.openafs.org/10934 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 3376bc13b8722cfb4435458cd8a0131121a7b026 Author: Andrew Deason Date: Mon Aug 12 17:37:29 2013 -0500 viced: Avoid endless BCB loop Without this commit, when we break callbacks for a fid, we loop over all callbacks for the fid, break a few of them, and then start over. We do this repeatedly until we run out of callbacks. If a client sees a callback break, and then establishes a new callback promise while the fileserver is still breaking callbacks, the fileserver can break the same callback for the same host again and again. This can continue forever, if the client establishes its new callback promises quickly enough. So to avoid this, when we start breaking callbacks, flag all of the callback structures that we want to look at. Then when we repeatedly loop through all of the callbacks for the fid, only look at the flagged callback structures. This adds a 'flags' field to struct CallBack, and defines a single flag, CBFLAG_BREAKING. This is an alternative fix to the issue also fixed in 843d705c. This implementation avoids allocating extra memory under locks, and has the slight benefit of not breaking callbacks that were elsewhere deleted during the BCB. This comes at the cost of a single extra traversal through our callback list, and the cost of claiming one of the bits in the CallBack structure. Reviewed-on: http://gerrit.openafs.org/10172 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Derrick Brashear (cherry picked from commit 47124f337b43f8731bfbe3bd71e42d046a4d1075) Change-Id: I522e0cecd0a9a10bf9eafaae669f4f0005ced893 Reviewed-on: http://gerrit.openafs.org/10755 Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Tested-by: BuildBot Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit dfa4f822f6696d1a3ba84ee9bfa63fce96fa503a Author: Benjamin Kaduk Date: Fri Mar 14 11:13:15 2014 -0400 libafs: DARWIN: update for Xcode 5.1 (1) remove -mlong-branch from amd64 build Random internet postings suggest that it has triggered a warning since at least Xcode 3.2, and the gcc manual page suggests that it is only applicable on ppc, anyway. (2) remove -mpreferred-stack-boundary=4 from the amd64 build The evidence here shows up less readily in an internet search, but it seems that Apple's compilers will force the stack alignment to 16 bytes regardless of what is passed here. One poster had trouble with -mpreferred-stack-boundary being unused in Xcode 4.4.1 This change only fixes warnings reported as errors by buildbot; it does not attempt to fully synchronize with the flags that Xcode 5.1 uses for kernel module builds. Reviewed-on: http://gerrit.openafs.org/10896 Tested-by: BuildBot Reviewed-by: D Brashear (cherry picked from commit cb18fbde6536942e4bc87bd5943a13cc14fbe332) Change-Id: Ic66d9028e4f15bd7a9d7c80db84087879560f4d2 Reviewed-on: http://gerrit.openafs.org/10926 Tested-by: BuildBot Tested-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 9ba0be640933e7b416328f248d050f02d4561212 Author: Benjamin Kaduk Date: Thu Mar 13 16:37:10 2014 -0400 Do not use garbage-collection for DARWIN ObjC apps Xcode 5.1 does not support this feature. Reviewed-on: http://gerrit.openafs.org/10890 Reviewed-by: D Brashear Tested-by: D Brashear (cherry picked from commit 52a9d1929518feab17b81b0a9db7ba45f69d5071) Change-Id: Ia383e1f9c4ee4ae19ed81cfedb1541399d7546b3 Reviewed-on: http://gerrit.openafs.org/10925 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 26c5e507afb28eb01ff49998321982cc355bac05 Author: Benjamin Kaduk Date: Thu Mar 13 15:33:44 2014 -0400 Use correct include guard for vol_prototypes.h Correct the case of the 'h'. Reviewed-on: http://gerrit.openafs.org/10889 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit 8832cd4e61f04fa5c650060e968bd7834afebd92) Change-Id: I306107184667724e48d5c9c32a11ddc4c9748ce7 Reviewed-on: http://gerrit.openafs.org/10924 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit bcd57ac2f7ec0a8bf364d1422ac21b7bbc8d0ddd Author: Benjamin Kaduk Date: Thu Mar 13 15:30:42 2014 -0400 Remove static const char copyright[] We do not have copyright strings in our other executables for the other copyright statements applicable to them, so these are rather exceptional. They also cause build failures with OS X Xcode 5.1 and --enable-checking . Reviewed-on: http://gerrit.openafs.org/10888 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit 3f189f8fe8cbb52aac4b7b5fe767d0de481cb569) Change-Id: I11f878e4e4077bd242364810e1aaa473a36bc08c Reviewed-on: http://gerrit.openafs.org/10923 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 03a9b481c7f27c462c9d65a756d172e79758b86d Author: Andrew Deason Date: Thu Apr 4 17:35:01 2013 -0500 viced: Avoid issuing redundant TMAY requests Currently, if a new Rx connection comes in from a host we already have a host struct for, we make a TellMeAboutYourself (TMAY) call to the given host, to verify the UUID (and caps, interface info, etc) is what we expect it to be. That is, if it's still the "same" host that we know about. This is necessary because we otherwise have no way of telling if the Rx connection is from the same host, or from a new host that just happens to have the same IP address (e.g. in the case that hosts are moving around and changing IPs). We do this while the host is locked, so we only issue these TMAY calls one at a time. If a large number of Rx connections come in from the same host at around the same time, this can result in a lot of TMAY requests being issued against the host, even for hosts that never change IPs and never do anything strange. In these situations, issuing so many TMAYs is useless. If we have several calls waiting to lock the host to issue a TMAY, some of the extra TMAY calls are provably useless. So instead of calling TMAY repeatedly, remember what the last successful TMAY result was, and reuse it for the "provably useless" calls. Note that this 'cache' stores the actual raw results of TellMeAboutYourself. We could save some memory by storing just how we interpret that data later on in h_GetHost_r, but this way results in way simpler h_GetHost_r logic. Since, we can use the same code paths as for a "real" TMAY call. Reviewed-on: http://gerrit.openafs.org/9711 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 9a0a8ca4d186cf953b87d9fae1a35f66090b060c) Change-Id: I0f0e6a4a1a56ea7992194cbabebf5f793a74f37a Reviewed-on: http://gerrit.openafs.org/10759 Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand Reviewed-by: Benjamin Kaduk Tested-by: BuildBot commit 8de5e707f16582b1cb9bc9be879e56462390ef1e Author: Michael Meffie Date: Sat Mar 15 11:31:27 2014 -0400 doc: fix typo in volinfo man page Reviewed-on: http://gerrit.openafs.org/10904 Reviewed-by: Ken Dreyer Tested-by: Ken Dreyer (cherry picked from commit 3a0c348d6ebc375f11d2bab70de9a00f5905fe94) Change-Id: I8a39bdc1cb4bff509d54ef7c76d4b8735505c0e1 Reviewed-on: http://gerrit.openafs.org/10931 Tested-by: BuildBot Reviewed-by: Ken Dreyer Reviewed-by: Stephan Wiesand commit 4750f4ce272f944cc8d02e4fedf6e78ea153d7f9 Author: Andrew Deason Date: Fri Jan 31 16:46:12 2014 -0600 afs: Throttle byte-range locks warnings per-file Currently, the warning messages about byte-range locks are throttled only according to what the last PID of the locking process was. So, if that same process performs a bunch of byte-range locks a bunch of times, we log this warning message at most once every 2 minutes. However, if we have even just one other process also performing byte-range locks, the throttling can become pretty useless as lastWarnPid ping-pongs back and forth between the two different PIDs. This can happen if multiple unrelated byte-range-lock-using pieces of software just happen to be running on the same machine, or if a piece of software uses byte-range locks after forking into separate processes. To avoid flooding the log in situations like this, keep track of the last warn time in the relevant vcache, so we don't get frequent warnings for byte-range lock requests on the same file. Reviewed-on: http://gerrit.openafs.org/10796 Reviewed-by: D Brashear Tested-by: BuildBot (cherry picked from commit 9f90b12e14e5511cb1c11cbc4d85cfa291be861f) Change-Id: Ia5426e97fa431e6b9eeb1c82e03c74c959249e9a Reviewed-on: http://gerrit.openafs.org/10839 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit f1d51b7cba81dde50193b3ed74eb6fcdb9e50328 Author: Andrew Deason Date: Fri Jan 31 16:40:35 2014 -0600 afs: Include FID in DoLockWarning Provide the FID that is being locked when we warn about byte-range locks, so the user can find what file the process is trying to lock. Reviewed-on: http://gerrit.openafs.org/10795 Reviewed-by: D Brashear Tested-by: D Brashear (cherry picked from commit 4f253106dc5d1a5280b0a5be393df0e87e00a661) Change-Id: I369e9505583c1b6b820b5bc54b8e4908ab8bf3e5 Reviewed-on: http://gerrit.openafs.org/10838 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 9d49c684286cbcb1e141cb1244c46968419cfba2 Author: Andrew Deason Date: Fri Jan 31 16:36:44 2014 -0600 afs: Refactor DoLockWarning Change DoLockWarning around a little bit, so subsequent changes are easier to follow. Move lastWarnTime/lastWarnPid so they are only usable within this function. This commit should incur no functional change. Reviewed-on: http://gerrit.openafs.org/10794 Tested-by: BuildBot Reviewed-by: D Brashear (cherry picked from commit c73883e7846fa0421cfac29830c27c9b6aacf5ed) Change-Id: Ie419aa5110f9c72f99514c8159c10582747601db Reviewed-on: http://gerrit.openafs.org/10837 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit bc1da21540a2787b9badd9e9153cea5cc3c01bac Author: Ben Kaduk Date: Mon May 6 23:03:42 2013 -0400 Apply cast from cfc9b348 to the else clause Clang on FreeBSD complains about format string mismatch as well. Reviewed-on: http://gerrit.openafs.org/9855 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 61caad06b7a95c27eae7aca0536bcffe61d3e31a) Change-Id: I24af455a4f2d2144d78b5e9030830b7233af353f Reviewed-on: http://gerrit.openafs.org/10836 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 716bce628f2eddd2acc28022ac5915a575f40d09 Author: Ben Kaduk Date: Tue Jul 9 23:12:43 2013 -0400 Alias "vos e" to "vos examine" This shortcut broke when endtrans was added, and some people have strong finger memory. Reviewed-on: http://gerrit.openafs.org/10081 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Derrick Brashear (cherry picked from commit 5e56298876f64b7c5f36c9dbe375b196a2951521) Change-Id: I9c9626768770c7b380060e26f81eee61cc7f7fab Reviewed-on: http://gerrit.openafs.org/10886 Reviewed-by: D Brashear Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 31b32e2e2f3d09a8ca5cd91a6f48be9ab72efe10 Author: Andrew Deason Date: Tue Oct 12 17:46:36 2010 -0500 viced: Add options for interrupting clients Add the -offline-timeout and -offline-shutdown-timeout options to the fileserver, to implement interrupting clients accessing volumes we are trying to take the volume offline. Document the new options. Currently this is only implemented for read operations. Implementing this for write operations and callback breaks will require more work. This also removes the VGetVolumeTimed interface from the volume package, since the fileserver was the only user and with this change the fileserver now uses the VGetVolumeWithCall interface. Reviewed-on: http://gerrit.openafs.org/2984 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 4f7a51aa5115a9073771bc396e25d510aeae71e8) Change-Id: I34967bb03a09e5655b02c9b7b39272cfe8f71d7b Reviewed-on: http://gerrit.openafs.org/10799 Reviewed-by: D Brashear Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 744d01a63b32d848af7a2aeee0280036f83cdbec Author: Andrew Deason Date: Fri Oct 29 11:29:37 2010 -0500 vol: Interrupt RX calls accessing offlining vols When we are waiting for a volume to go offline, only wait a certain amount of time for it to go offline before we interrupt all RX calls associated with that volume. This amount of time is configurable in the new offline_timeout and offline_shutdown_timeout volume package option fields. Reviewed-on: http://gerrit.openafs.org/3216 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 57a5da63439c2e2b88dd32dc8aa42dc2f6eef116) Change-Id: I331d7ca09f17e5fc74de0c5da40c18b67e124cff Reviewed-on: http://gerrit.openafs.org/6266 Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 53da61120b65578e2a5de52f53eb3f47da37b06e Author: Andrew Deason Date: Tue May 10 13:45:26 2011 -0500 libafs: GiveUpAllCallBacks at shutdown again Commit cee2c677d7de66a510d05978e3b41dcd5d8aca78 caused the cache manager to give up all callbacks at shutdown. But 76158df491f47de56d1febe1d1d2d17d316c9a74 removed the call to afs_FlushVCBs in afs_shutdown. Put it back. Reviewed-on: http://gerrit.openafs.org/4640 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 330cc7c83bf8470e1e63f6e6d514f1e82008f167) Change-Id: I9c2b309b482a735f5cce57aa7497b67858db2c3e Reviewed-on: http://gerrit.openafs.org/10855 Tested-by: Andrew Deason Tested-by: BuildBot Tested-by: Stephan Wiesand Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 040b9333ea416cec8f4d5b6b674464847efc8e31 Author: Andrew Deason Date: Thu May 5 11:37:12 2011 -0500 libafs: Correct GUACB afs_LoopServers flags Use the named constant AFS_LS_ALL. This change is 1.6-specific, and contains only part of 1f48bc7a30d5df88a1e5f539ee22df3952533a88. The rest of 1f48bc7a30d5df88a1e5f539ee22df3952533a88 was committed in 4c4075ade0d46087638bd8cc96aa9fac005e62f3, before the FlushAllVCBs call was added. Reviewed-on: http://gerrit.openafs.org/4624 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 1f48bc7a30d5df88a1e5f539ee22df3952533a88) Change-Id: I9284abe1cb9752c5204b9b1c91438983d854a864 Reviewed-on: http://gerrit.openafs.org/8840 Tested-by: BuildBot Tested-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 372cf44895b368b12add5fcb9715754bbcee5599 Author: Derrick Brashear Date: Wed Dec 1 15:23:11 2010 -0500 unix: giveupallcallbacks at shutdown just try to give up callbacks at shutdown. at this point if you're running 1.4.5 or older, you're sad anyway. Reviewed-on: http://gerrit.openafs.org/3404 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear (cherry picked from commit cee2c677d7de66a510d05978e3b41dcd5d8aca78) Change-Id: I56e6b9e0e5f2921126a468854a1735b257e05219 Reviewed-on: http://gerrit.openafs.org/6272 Tested-by: BuildBot Tested-by: Andrew Deason Tested-by: Stephan Wiesand Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit b5f8c9f3f5d3aea06e572f2eb5e636deb0f2cfe9 Author: Marc Dionne Date: Fri Jul 5 12:50:36 2013 -0400 bos: Do encryption if requested Commit d008089a79 didn't replace the processing of the aencrypt flag passed to the GetConn() function, causing all bos connections to be un-encrypted. This causes "addkey" to fail with an error from the server, and "listkeys" to silently ignore the -showkey option to display keys. Set the AFSCONF_SECOPTS_ALWAYSENCRYPT flag, and don't set AFSCONF_SECOPTS_FALLBACK_NULL since fallback is not acceptable if the caller requested enrcyption. Reviewed-on: http://gerrit.openafs.org/10043 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 7565cb420366d79df319e344678a8d9ceab6db08) Change-Id: Ibc643a352ed560ad0f32cbff61167463e16201ee Reviewed-on: http://gerrit.openafs.org/10863 Tested-by: BuildBot Reviewed-by: Perry Ruiter Reviewed-by: Jeffrey Altman Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit d2d749ec0c656d6e4c595a5f8c93b164a6cf911b Author: Simon Wilkinson Date: Fri Mar 8 16:15:51 2013 +0000 bos: Remove theoretical overflow in DateOf DateOf copies the results of ctime into a static buffer. Typically ctime will return a 26 byte string, but if you pass it a year larger than 9999 (which we shouldn't), you can get a 32 (or more) byte string. Get rid of this unlikely event by using strlcpy for the copy. We already truncate at 24 bytes when we remove the \n, so this shouldn't cause any further problems. Really, this whole thing should be rewritten to use strftime. Caught by coverity (#985776) Reviewed-on: http://gerrit.openafs.org/9551 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit 8b76110e23160e33716234f9560d22ca5275cb0a) Change-Id: I47bdadf0159c12d747040765d28e6e8908678fd1 Reviewed-on: http://gerrit.openafs.org/10862 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 53773034aa5c33009ddaa7d42a89c3d17cf85668 Author: Simon Wilkinson Date: Fri Mar 8 13:02:26 2013 +0000 bos: Don't overflow buffer with key data When parsing key data from the command line, don't overflow the buffer used to hold it - instead just give an error if the data is too long. Caught by coverity (#985775) Reviewed-on: http://gerrit.openafs.org/9550 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit 4e9c6eb9d5192888d79a07042c9cb6029def9726) Change-Id: Ic1892ba4cd5e69c48003073a758a47a08b84a890 Reviewed-on: http://gerrit.openafs.org/10861 Tested-by: BuildBot Reviewed-by: Perry Ruiter Reviewed-by: Jeffrey Altman Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 538faed7f79f48864cb8bccf4c4f819f55d9c0ca Author: Simon Wilkinson Date: Fri Mar 8 13:01:28 2013 +0000 bos: Don't overflow cellname buffer Don't overflow the fixed sized cellname buffer when copying the information in from the command line - instead, just use a dynamically allocated buffer. Caught by coverity (#985775) Reviewed-on: http://gerrit.openafs.org/9549 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 45993e3ad55358c3e94105e2e3aa13df43f5fdd3) Change-Id: Idb2b165c9b08f72cb57ca879ff6d61f9d556a631 Reviewed-on: http://gerrit.openafs.org/10860 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 3a1a4c4fc7ff1233cda8da19c93cc4c7ddd7e589 Author: Simon Wilkinson Date: Thu Feb 21 21:29:56 2013 +0000 bos: Don't set up the conenction twice in AddKey AddKey calls GetConn twice - once at the start of the function, and then again immediately before calling BOZO_AddKey. This leaks a connection... Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9230 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear (cherry picked from commit 6ef224da14da88318ede836a2c80998299c93e2f) Change-Id: I6cbd68a72b041a9638d98481ef793e34b8946abd Reviewed-on: http://gerrit.openafs.org/10859 Tested-by: BuildBot Reviewed-by: Perry Ruiter Reviewed-by: Jeffrey Altman Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit a416b983a339bfa4a80a65abc170cc4d1917876e Author: Michael Meffie Date: Thu Mar 6 11:42:52 2014 -0500 doc: fix typo on ka-forwarder man page Reviewed-on: http://gerrit.openafs.org/10873 Reviewed-by: Stephan Wiesand Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit 189a17146e789f2cf716ed3a477ed6f54776df12) Change-Id: Ic4e2f4cc2947946a5e41bb71152ef6d5683048f4 Reviewed-on: http://gerrit.openafs.org/10875 Reviewed-by: Ken Dreyer Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 8f6a814016fa7a8ef4bbe55425f9a9f4c66cb824 Author: Michael Meffie Date: Mon Dec 23 12:10:36 2013 -0500 vol: reset nextVnodeUnique when uniquifier rolls over The on disk uniquifier counter is set to 200 more than the current nextVnodeUnique counter when the volume information is updated to disk. When the nextVnodeUnique is near UINT32_MAX, then the uniquifier counter rolls over. This can happen during a volume header update due to VBumpVolumeUsage_r(). With this change, the nextVnodeUnique customer is reset to 2 and the uniquifier is reset to 202 when a roll over occurs. (uniquifier of 1 is reserved for the root vnode.) With this change, the number of possible uniquifier numbers is limited to 200 less than UINT32_MAX. The following shows a series of vnode creation/deletions to illustrate the uniquifier rollover before this commit: fid = 536870918.4.4294967114, nextVnodeUnique = 4294967115, uniquifier = 4294967295 fid = 536870918.4.4294967115, nextVnodeUnique = 4294967116, uniquifier = 4294967295 fid = 536870918.4.4294967116, nextVnodeUnique = 4294967117, uniquifier = 21 fid = 536870918.4.4294967117, nextVnodeUnique = 4294967118, uniquifier = 22 and after this commit: fid = 536870918.4.4294967115, nextVnodeUnique = 4294967116, uniquifier = 4294967295 fid = 536870918.4.4294967116, nextVnodeUnique = 2, uniquifier = 202 fid = 536870918.4.2, nextVnodeUnique = 3, uniquifier = 202 fid = 536870918.4.3, nextVnodeUnique = 4, uniquifier = 202 Reviewed-on: http://gerrit.openafs.org/10617 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 64d7715c0247734731ef4cc8be5de32ee7c4a1f6) Change-Id: Ieead6921f8ebca436cbcaecbf7711236c6cdf0e9 Reviewed-on: http://gerrit.openafs.org/10847 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 4b6f0efba23d855cc79b8d503242589be9ac7ce2 Author: Michael Meffie Date: Mon Dec 23 11:42:19 2013 -0500 vol: fix nextVnodeUnique roll over Fixes for the per volume nextVnodeUnique counter roll over. Uniquifier number 1 is reserved for the root vnode, so reset the unique count to 2 when the nextVnodeUnique counter rolls over. Update the disk backed V_uniquifier count when the in-memory nextVnodeUnique counter rolls over during the creation of a new vnode. If the nextVnodeUnique rolls over when V_uniquifier is UINT32_MAX, then the V_uniquifier is not updated and remains at UINT32_MAX until the next VUpdateVolume_r() call for the volume. This bug is usually masked by the VBumpVolumeUsage(), which on every 128 volume accesses, bumps the V_uniquifier to be 200 more than the current nextVnodeUnique counter. This causes the V_uniquifier to roll over before reaching UINT32_MAX. (The number of access before updating the headers is set in the usage_threshold volume package option, which is currently set to 128 by default.) The following shows the unique counters for a series of vnode creation/deletions before this commit. The nextVnodeUnique rolls over to 1, and the uniquifier is not reset. The `usage_threshold' was set to a value greater than 200 to avoid the VBumpVolumeUsage() calls during this test run. fid = 536870918.4.4294967294, nextVnodeUnique = 4294967295, uniquifier = 4294967295 fid = 536870918.4.4294967295, nextVnodeUnique = 0, uniquifier = 4294967295 fid = 536870918.4.1, nextVnodeUnique = 2, uniquifier = 4294967295 fid = 536870918.4.2, nextVnodeUnique = 3, uniquifier = 4294967295 The following shows the unique counters after this commit: fid = 536870918.4.4294967294, nextVnodeUnique = 4294967295, uniquifier = 4294967295 fid = 536870918.4.4294967295, nextVnodeUnique = 0, uniquifier = 4294967295 fid = 536870918.4.2, nextVnodeUnique = 3, uniquifier = 203 fid = 536870918.4.3, nextVnodeUnique = 4, uniquifier = 203 Reviewed-on: http://gerrit.openafs.org/10616 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 1a287c631ead0221828ae70e10c3cfd5563fdfb7) Change-Id: I4d2bca2f3f1763f00e12de98f9dc4534c2ae51de Reviewed-on: http://gerrit.openafs.org/10846 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 346982f3f13b16c1b1e0aa1e8ddb0534a7f6d4a0 Author: Andrew Deason Date: Wed Sep 18 16:56:23 2013 -0500 vol: Nuke parent vol special inodes When we "nuke" a volume, we delete all inodes we can find that are for the given volume id. This currently means that if we nuke an RW volume id, we delete all of the inodes for file data for the entire volume group (since they're all stored in the VG id), but we do not delete the special inodes for any non-RW volumes in that volume group. Those special inodes left behind are not very useful, since we just deleted all of the actual file data. Currently this means that on namei, it's impossible to nuke the special inodes for non-RW volumes, since the namei nuke will only look in the subdir for the given volume id. If you give it the RW volume id, it won't delete the special inodes as menioned above; if you give it the RO volume id, it will only look in the RO subdir, and won't find the RO special inodes in the RW subdir. If a volume group is damaged in such a way that the salvager cannot fix it (due to a bug), this means that it is impossible to get rid of that volume group completely from the partition on namei without manually running "rm -rf" on the relevant AFSIDat directory. Normally we have a failsafe of running 'vos zap -force', but that doesn't work for non-RW special inodes, as mentioned above. So, in order to allow this 'vos zap -force' failsafe to work in hopefully all situations, also delete the special inodes for the parent volume. Use similar logic as exists in the salvager's OnlyOneVolume function. Reviewed-on: http://gerrit.openafs.org/10256 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit d83c1231cf371ac998304cbb2007ca848a514e0c) Change-Id: I80216cb73b9bc8edb7e6dca735a522d7132017dd Reviewed-on: http://gerrit.openafs.org/10772 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 326d46bdb846db6564bef9799a844c75adf981f3 Author: Andrew Deason Date: Thu Oct 3 12:51:41 2013 -0500 salvager: Handle multiple/inconsistent linktables The ListAFSSubDirs code in namei_ops.c currently detects incorrectly-named linktable files, and whines about them and says the salvager will handle them. However, the salvager doesn't really handle them, since we just use the first linktable we find (FindLinkHandle) without checking any of the information about it. So, check for these. Fix FindLinkHandle to only consider a linktable the "real" linktable to use if it actually matches the volume group id we're salvaging. Also delete any inconsistent linktables via the new function CheckDupLinktable later on. Note that inconsistently-named linktables have been known to have been created in the past due to a bug in the salvager (fixed by ae227049), and possibly due to other unknown issues. Reviewed-on: http://gerrit.openafs.org/10322 Reviewed-by: Mark Vitale Tested-by: BuildBot Reviewed-by: D Brashear (cherry picked from commit 602e8eb2000be02ef2a6627633b7ba80ea847762) Change-Id: I472e250bbe5dcb4de44111ac705c9a319abf2b44 Reviewed-on: http://gerrit.openafs.org/10811 Reviewed-by: D Brashear Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 1437175df5c8c799d11c92eaeaf3470534cbcb9b Author: Andrew Deason Date: Fri Aug 30 14:21:16 2013 -0500 namei: Ignore misplaced files The namei salvaging/ListViceInodes code currently ignores files where we cannot derive an inode number from a given filename. However, if a file is a valid inode filename, but is in the wrong directory, we still record it. This can cause the salvager to abort, since it assumes inode e.g. 12345 is present, but when it tries to open 12345, namei translates the inode to a nonexistant path, and we bail out. It is unknown how a namei directory structure can reach this state, but try to handle it. To be on the safe side, just ignore the files, and log a message about them. That way, if the files are required for reconstructing the volume or contain important data, they are still available if needed. And if they contain incorrect or old data, we don't screw up the volume by trying to use them. Thanks to Sabah S. Salih for reporting a related issue. Reviewed-on: http://gerrit.openafs.org/10214 Reviewed-by: D Brashear Tested-by: BuildBot (cherry picked from commit 1096582bde6156bb469f2e397cbc40d13a8f2822) Change-Id: I9252877fbfe01328ac4a8692ebe28a86913b9713 Reviewed-on: http://gerrit.openafs.org/10810 Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit ac20b369188e259037b0d9dfaa4353e45e87e8f6 Author: Andrew Deason Date: Thu Oct 3 12:38:08 2013 -0500 salvager: Ignore linktable-only RW volumes In general, the salvager will try to salvage any volume if we find an inode for that volume. However, for namei, we'll always have at least one inode for the RW volume, even if we only have e.g. an RO volume at a particular site, since the linktable special inode is always marked as for the RW volume id. So, if we salvage a volume group that only has an RO, normally we would also try to salvage the corresponding RW, even if it doesn't exist. We would then recreate the "missing" metadata files, so after salvaging, the RW appears to exist as a normal volume. The salvager currently tries to avoid this by skipping salvaging the RW if we find more than one volume in the volume group, and if the RW only has one special inode, and that one special inode is the linktable. This solves the problem most of the time, but misses a few corner cases: - If we found more than one linktable, we'll try to salvage the RW anyway. This shouldn't happen, but certain cases of corruption can cause incorrectly-named linktables, resulting in multiple linktables. - If we only find one volume (the RW), we'll still salvage the RW, even if the only inode for it is a single linktable. This can happen due to botched salvages in the past, or interrupted deletes and such. It's just cruft. In any situation like those, we cause an RW volume to be created where there previously was none. This can be a problem, since the RW volume is unknown to the administrator, and does not appear in the VLDB. Such "phantom" volumes can be very confusing and can cause problems in the future. For example, if that same RW volume is moved to the server with the "phantom" RW volume, we now have two of the same RW volume on the same server on different partitions, which is a big problem. So, to avoid these corner cases, check all of the special inodes to see if all of them are linktables. Also perform this check if we don't have any non-special inodes (even if we only see 1 volume), to catch the "cruft" case above. Reviewed-on: http://gerrit.openafs.org/10321 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 600712877ca0883c6ec609d51909336964b06cba) Change-Id: Ia8fb952df3e7a2e85f47d9d9e903239e349791d9 Reviewed-on: http://gerrit.openafs.org/10771 Reviewed-by: Andrew Deason Reviewed-by: D Brashear Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 65847d19c6a795709cb5523e5927e5d0a9b24302 Author: Andrew Deason Date: Tue Oct 1 17:31:44 2013 -0500 namei: Set inconsistent linktable linkCount to 0 Currently, if we detect an inconsistent linktable filename (where the filename indicates it's for a different volume than the directory path indicates), we don't set the linkCount for the inode info. This means that our caller will get random garbage for the linkCount. In many cases this value is ignored, but for the salvager, if this is the only linktable file we find, we treat it as the linktable we should be using. Thus, if linkCount contains undefined data, we might try to INC or DEC the linktable a bunch of times, depending on what random stack garbage the linkCount is filled with. The salvager shouldn't be INC/DEC'ing these linktables according to the their linkCount anyway, but in the meantime, at least ensure that this doesn't contain stack garbage, so we ensure that we won't try to INC or DEC this thousands or millions of times. Reviewed-on: http://gerrit.openafs.org/10320 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 2286fac1447e2e9e834957ec414cb5605f51e63b) Change-Id: I480ad328d594531869874b4207629533553bfc64 Reviewed-on: http://gerrit.openafs.org/10770 Reviewed-by: Andrew Deason Reviewed-by: D Brashear Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit e10a3efe5828e4f1f98ea456d8507e9a93b023ab Author: Andrew Deason Date: Tue Aug 14 17:25:44 2012 -0500 viced: Move host quota calculation Calculate this during initialization, not every time we want to use it. Reviewed-on: http://gerrit.openafs.org/9710 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 31b518fcf184ba122b6faab54e2e4fa0d37605a3) Change-Id: Ia4bb30b31e2e3ce25ea16d5932f8f3ae26210c11 Reviewed-on: http://gerrit.openafs.org/10758 Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit fd4bb48075a6ba1d38a5852fe08883dea2f007d7 Author: Andrew Deason Date: Fri Feb 22 22:46:12 2013 -0600 viced: Improve CallPreamble error messages These messages are not very useful right now. At least try to say what host we sent an error to, so we know which host may be experiencing some troubles as a result. Reviewed-on: http://gerrit.openafs.org/9381 Reviewed-by: Mark Vitale Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 6c41b1f740e16b5b9adfe9026630595be6f0699e) Change-Id: I4e9cf5e0d038c572895b4a31bfdff481ea0b3286 Reviewed-on: http://gerrit.openafs.org/10756 Reviewed-by: Andrew Deason Reviewed-by: Mark Vitale Reviewed-by: Benjamin Kaduk Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 4e7e1d0c4b8dfb70b48ea20837f6657a2bce2184 Author: Andrew Deason Date: Mon Jan 27 18:03:59 2014 -0600 afs: Translate VNOSERVICE to ETIMEDOUT Some fileservers will kill calls that are taking too long with the VNOSERVICE abort code. Our logic for retrying calls is already aware of this usage, but if we cannot retry the call, we still just return VNOSERVICE as an error code to our caller. Don't return this raw, since has the same value as ENOBUFS, which can cause a confusing error message from logs or applications ("No buffer space available"). Return ETIMEDOUT instead. Reviewed-on: http://gerrit.openafs.org/10766 Reviewed-by: Derrick Brashear Tested-by: Andrew Deason (cherry picked from commit 335a70653adb59795f262663af3972de016c068d) Change-Id: Ia0b4dbfb61353c08917898c3cb9128625023f311 Reviewed-on: http://gerrit.openafs.org/10814 Reviewed-by: Perry Ruiter Tested-by: BuildBot Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 7ee0beb5ed58161fb452e88324eaf16cad626f8b Author: Andrew Deason Date: Thu Dec 26 16:42:46 2013 -0500 afs: Treat vc_error as a CheckCode-translated code The vcache field vc_error is generally treated as an error code that has been translated through afs_CheckCode, but this is inconsistent in a few places. Fix this in a few ways: - Adjust afs_nfsrdwr so we do not call afs_CheckCode on vc_error, translating the error code twice. - Change afs_close to store vc_error in code_checkcode, and have the logging code check for specific values in code_checkcode as well. Log unknown values of code and code_checkcode, so we can distinguish between e.g. a 'code' value of VBUSY, and a 'code_checkcode' value of ETIMEDOUT. Reviewed-on: http://gerrit.openafs.org/10634 Reviewed-by: Benjamin Kaduk Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 34e4a4fed356fbda9fc8ace1d01a080bd09238b0) Change-Id: Icceee0c82b0704e0d445f96946b493b4be424506 Reviewed-on: http://gerrit.openafs.org/10813 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 1dd3a383cb1e192b042bbbe7b62d25915bb88e5f Author: Andrew Deason Date: Fri Dec 20 12:16:37 2013 -0600 afs: Return raw code from background daemons Currently, a background daemon processing a 'store' request will return any error code in the 'code' field in the brequest structure, for processing by anyone that's waiting for the response. Since any waiter will not have access to the treq for the request, they won't be able to call afs_CheckCode on that return code, so the background daemon calls afs_CheckCode before returning its error code. Currently, afs_close uses the 'code' value from the background daemon as if it were not passed through afs_CheckCode. That is, if all background daemons are busy, we get our 'code' directly from afs_StoreOnLastReference, and if we use a background daemon, our 'code' is tb->code. But these values are two different things: the return value from afs_StoreOnLastReference is a raw error code, and the code from the background daemon (tb->code) has been translated through afs_CheckCode. This can be confusing, in particular for the scenario where a StoreData fails because of network errors or because of a VBUSY error. If we get a network error when the request went through a background daemon, afs_CheckCode will translate this to ETIMEDOUT, which is commonly value 110, the same as VBUSY. So, an ETIMEDOUT error from the background daemon is difficult to distinguish from a VBUSY error from a direct afs_StoreOnLastReference call. Either case can result in a message to the kernel like the following: afs: failed to store file (110) To resolve this, have the background daemon store both the 'raw' error code, and the error code that has been translated through afs_CheckCode. afs_close can then use the raw error code when reporting messages like normal, but can still use the translated error code to return to the caller, if it has a translated error. With this change, now afs_close will always log "network problems" for a network error, regardless of if the error came in via a background daemon or a direct afs_StoreOnLastReference call. In Irix's afs_delmap, we just remove the old usage of tb->code, since the result was not used for anything. Reviewed-on: http://gerrit.openafs.org/10633 Reviewed-by: Benjamin Kaduk Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 7f58e4ac454f9c06fb2d51ff0a17b8656c454efe) Change-Id: Id5935d41b0d20000f06b39c48649cd7d0dd2fd81 Reviewed-on: http://gerrit.openafs.org/10812 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 3f9cf37b7b78ad9523bb93c67ad5eff0d0e371aa Author: Andrew Deason Date: Mon Sep 30 17:53:36 2013 -0500 salvager: Fix in-memory invalid linktable counts When we have a nonexistant or invalid linktable, we manually set all of the linkcounts to 1, since we're recreating the link table from scratch. However, we also have a linkCount count in our in-memory allInodes array, which could be populated by garbage if we had a garbage linktable. So make sure to set our in-memory linkCount to 1 for each inode, so we don't use garbage linkcount data. Reviewed-on: http://gerrit.openafs.org/10312 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 6a4831e0e9a003bed06ac2269987c69090d3f7e7) Change-Id: Ic580176f0350a2f44b60f1b448cf3da8a091e36d Reviewed-on: http://gerrit.openafs.org/10769 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit e4c83c5c17b19d3ad599b48a1cfabd5f90275594 Author: Simon Wilkinson Date: Fri Mar 30 19:41:17 2012 +0100 afs: Handle reading past the end of a file ... except that this change doesn't actually handle this, it just stops clang from throwing an error about the bogus code that's already in there. This needs fixed properly ... Reviewed-on: http://gerrit.openafs.org/7090 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 3198cef8ccf0d9cb9a7479c0b973e604e21e62fc) This change differs slightly from the one on master because on master, afs_MemRead and afs_UFSRead were consolidated into afs_read(). On the 1.6 branch, we must patch the two functions separately. Change-Id: I7d8d104c89355c0a3294372340af0e02ab170b59 Reviewed-on: http://gerrit.openafs.org/10744 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 618343f0261bb5ffa036d93f1a3bc313ed76a037 Author: Andrew Deason Date: Tue Dec 10 17:02:34 2013 -0600 cellconfig: Do not use 'long' for dbserver IPs A few places in this file assume that our dbserver IP addresses are "long"s. A long int can be 8 bytes on some platforms, but we know these IP addresses are all 4-byte integers. In the rare instances where we have the maximum number of dbservers, this can overwrite a bit of extra memory. This can also result in a misaligned access on platforms such as SPARC v9, since the elements of he->h_addr_list are not guaranteed to be 8-byte aligned. So instead, treat these as 4-byte integers. For copying out of he->h_addr_list, also use a memcpy anyway to be safe, since we are not guaranteed alignment. Reviewed-on: http://gerrit.openafs.org/10599 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit d8f75d3206eaa56b3a819a5bc13a4bf3a9130512) Change-Id: I2568577b05f47ebc75b34a9cd106fceac8a31ef7 Reviewed-on: http://gerrit.openafs.org/10603 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit 3166cba243e6e69f52fedfe81ea4d407eb6553e1 Author: Andrew Deason Date: Thu Feb 6 14:27:12 2014 -0600 ihandle: Make _ONCLOSE the sync behavior default The _DELAYED behavior has had serious problems in the past, so change the default to be _ONCLOSE instead. This is a 1.6-only change. On master, the _DELAYED option does not exist at all, and the _ONCLOSE behavior was made the default when this option was introduced in master, in commit eb5190eb4a7cd95166866a89e0a8f3a69bbc6e8f. Change-Id: I01a50e1d829c141c38fbbbaba2c6d2d5a371b130 Reviewed-on: http://gerrit.openafs.org/10809 Tested-by: BuildBot Reviewed-by: Perry Ruiter Reviewed-by: Andrew Deason Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 2667f59e12ddba9d73c9996a28d7c63414887713 Author: Benjamin Kaduk Date: Wed Feb 5 18:32:16 2014 -0500 afs_fetchstore: re-avoid uninitialized variable As noted in the gerrit comments for change 10742, commit baf6af8a8f2207ce39b746d59ca4bc661c002883 does not handle the case where the second rx_Read() call fails, and the 'length' variable can still be used uninitialized. Instead of using an err label and jumping to it on the case of errors, initialize length to zero and take care to neither set nor access *alength if an error has occurred. This is more consistent with the style of the surrounding code while still avoiding the use of an uninitialized variable. Reviewed-on: http://gerrit.openafs.org/10806 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit b7326e487f6387033282cc5d1128b00a0456673a) Change-Id: I371ec319b9a984e61e41a30110b8f2c0cf14b379 Reviewed-on: http://gerrit.openafs.org/10835 Tested-by: BuildBot Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 596b464d20150bbb816176cb278e2e9c845edecd Author: Benjamin Kaduk Date: Thu Jan 9 22:42:26 2014 -0500 afs_fetchstore: avoid use of uninitialized variable rxfs_fetchInit() attempts to do a 64-bit RPC first, but falls back to the 32-bit StartRXAFS_FetchData() if the server appears to not support the 64-bit RPCs. We correctly did not read a length from the call if the FetchData RPC(s) failed, but proceeded to assign from the 'length' local variable into the 'alength' output variable unconditionally later on. Instead of blindly continuing on, jump to the error-handling part of the routine when we cannot read a length from the call. This has the side effect of skipping an afs_Trace3() point in the error case. Reviewed-on: http://gerrit.openafs.org/10694 Reviewed-by: Derrick Brashear Tested-by: Benjamin Kaduk (cherry picked from commit baf6af8a8f2207ce39b746d59ca4bc661c002883) Change-Id: Icf14d5e8a6abf8a8a014ab7d48b767e3dcc7a6a9 Reviewed-on: http://gerrit.openafs.org/10742 Tested-by: BuildBot Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit a7d8601253f17943c994dff9be79f00d6d281ff5 Author: Andrew Deason Date: Tue Dec 17 17:30:26 2013 -0600 LINUX: Use sock_create_kern where available Currently, we use sock_create to create our Rx socket. This means that accesses to that socket (sendmsg, recvmsg) are subject to SELinux restrictions. For all recvmsg accesses and some sendmsg accesses, this doesn't matter, since the access will be performed by one of our kernel threads (running as kernel_t or something similar, which is unrestricted). Such as: the rx listener, a background daemon, the rx event thread, etc. However, sometimes we do run in the context of a normal user process. For some RPCs like FetchStatus, we tend to run the RPC in the accessing user thread, which can result in us sendmsg()ing the data packets with the initial arguments in the user thread. We can also send delayed ACKs via rx_EndCall, and possibly a variety of other scenarios. In any of these situations when we are sendmsg()ing from a user thread, SELinux can prevent us from sending to the socket, if the calling user thread context is not able to write to an afs_t udp_socket. This will result in packets not being sent immediately, but the packets will be resent later, so access will work, but appear very slow. This can easily happen for processes that are specifically constrained by SELinux; for example, webservers are often constrained, even if most of the rest of the system is not. This can be noticed by seeing the 'resends' and 'sendFailed' counters rising in 'rxdebug -rxstat', as well as noticing SELinux access failures if 'dontaudit' rules are ignored. To avoid this, use sock_create_kern to create the Rx socket, to indicate that this is a socket for use by kernel code, and not accessible by a user. This should cause us to bypass any LSM restrictions (SELinux, AppArmor, etc). Add a configure check for this, since this function has not always existed, according to Reviewed-on: http://gerrit.openafs.org/10594 Tested-by: BuildBot Reviewed-by: Marc Dionne Reviewed-by: Michael Meffie Reviewed-by: Derrick Brashear (cherry picked from commit e988aa45d765c935fef4bcd35585d6a3594cc497) Change-Id: Ie04a8ac166dabf9fb8368d47d5624d1f319174bd Reviewed-on: http://gerrit.openafs.org/10598 Reviewed-by: Andrew Deason Reviewed-by: Marc Dionne Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand Reviewed-by: Michael Meffie Tested-by: BuildBot commit ea6e7d76ebc696cc1a18246fc535cae3e76656d0 Author: Simon Wilkinson Date: Fri Mar 30 19:34:53 2012 +0100 viced: Remove pointless braces Doing if ((a==b)) is unecessary. It's also potentially dangerous, as that's the syntax required to do assignment within an if statement. clang now issues warnings (errors in -Werror mode) when it encounters these. Remove pointless braces from viced to make clang happy. Reviewed-on: http://gerrit.openafs.org/7085 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 6d83b33324b68389d0cb8fee73f3bf3a06e9abe5) Change-Id: Ied4eb404108e7d8384cc394d5f5e65a04beb17dc Reviewed-on: http://gerrit.openafs.org/10747 Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit dda87b13a5464aa345b8d405da4afc6ce0c4cd6a Author: Marc Dionne Date: Thu Jan 30 13:50:37 2014 -0500 Linux: When revalidating, don't drop in-use dentries The Linux client can get into a state where the current working directory is seen as "deleted" by some tools, while it is still there and accessible to "ls" and other tools. This has been reported by several users and sites. One scenario that has been observed while debugging: - A process does a chdir() into a directory - This stores a pointer to the dir's dentry in the task structure - The server hosting the volume goes offline temporarily - The dentry for the directory is passed to afs_linux_dentry_revalidate - afs_linux_dentry_revalidate calls afs_lookup which returns an error (110 - ETIMEDOUT) - It then considers the dentry not valid, and calls d_drop() - d_drop unhashes the dentry unconditionally - Server comes back up, but dentry is still unhashed - getcwd() fetches the task structure pointer to the current dir dentry. If unhashed, it returns ENOENT, and the vfs layer is not involved at all. At that point, many things won't work and there is no obvious way for the user to get the directory rehashed. Instead of calling d_drop directly, call d_invalidate instead, as it will only drop (unhash) the dentry if we're the only one holding a reference. Since d_invalidate will also call shrink_dcache_parent, also remove that call from our code so it doesn't get called twice. Reviewed-on: http://gerrit.openafs.org/10774 Tested-by: BuildBot Tested-by: Anders Kaseorg Reviewed-by: Derrick Brashear (cherry picked from commit 997f7fce437787a45ae0584beaae43affbd37cce) Change-Id: I1e2b46fd076e96a7acbf3443f118fac8355d3e8c Reviewed-on: http://gerrit.openafs.org/10804 Tested-by: Anders Kaseorg Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Marc Dionne Reviewed-by: D Brashear Reviewed-by: Stephan Wiesand commit 568a8872ae0fb038d9364af426513389791685ae Author: Stephan Wiesand Date: Fri Jan 31 17:01:06 2014 +0100 RedHat: don't package manpages for binaries not included We don't package copyauth, aklog_dynamic_auth and rmtsysd. Omit their manpages too. Reviewed-on: http://gerrit.openafs.org/10781 Reviewed-by: Ken Dreyer Tested-by: BuildBot Reviewed-by: D Brashear (cherry picked from commit b78b7f0c3454be02048e4533ee26ef28dc8f78ff) Change-Id: Ifb52d8bcc19940b3725d7bbe616df70c9bd1a948 Reviewed-on: http://gerrit.openafs.org/10807 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Ken Dreyer Reviewed-by: Stephan Wiesand commit 23709f03a38eca661529b745b185393a0a239835 Author: Benjamin Kaduk Date: Thu Jan 9 23:34:30 2014 -0500 Disable some explicit sbrk() usage Mac OS X 10.9 now considers this function deprecated and warns on its use, causing the buildslave configuration to error out. On master, we added a library routine to get a process's size to opr; opr is not present on the 1.6 branch so another route is needed here. Since use of the OS X malloc implementation appears to have no effect on the result of sbrk(0), there is no loss of functionality by replacing the function call with a (different) constant value. There may still be some value in sbrk(0) on other systems, so only disable sbrk() for OS X, on the stable branch. This change is specific to the 1.6 branch. Change-Id: Ie5f96e923b78be22a9ce83d0a35a7675d517b073 Reviewed-on: http://gerrit.openafs.org/10746 Tested-by: BuildBot Reviewed-by: D Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 473322a453bbc409d54ab21e1d9637eaf15f085a Author: Benjamin Kaduk Date: Wed Jan 22 06:00:00 2014 +0100 cmd: Avoid unsafe use of strncat The NName function was using strncat(a, b, sizeof(a)), which doesn't work as you would expect if 'a' already contains data, giving a potential buffer overflow. This was fixed on master in commit 9a007a9df43645b63a8b642029b4931928f9268b by using strlcat from libroken, but we do not use libroken on the 1.6 branch. Instead, modify the strncat invocation to use a safer maximum length to copy. This is a 1.6-specific change. Change-Id: Ifa41e603a1c98682550afadd063def4b9706d9e2 Reviewed-on: http://gerrit.openafs.org/10731 Tested-by: BuildBot Reviewed-by: D Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit 9987cb6cc35463eaf87d209e741aacf5c621d894 Author: Benjamin Kaduk Date: Tue Jan 21 14:59:59 2014 -0500 Search srcdir and objdir paths for rxkad includes The addition of rxkad-k5 support in 1.6.5 introduced dependencies on rxkad to the auth and afsauthent libraries. However, the rxkad headers used are both source files and generated files, so we must add both the source and build tree rxkad directories to the include search path. This is a 1.6-only change, since on master we are using libtool and do not need to reach into other parts of the source tree to rebuild certain files into these libraries. Change-Id: I819095a3e0ac259bba43205d0462659cbd2c6f03 Reviewed-on: http://gerrit.openafs.org/10736 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand commit 2313e78e82354390e76ec0d24c7f2229c901e18e Author: Mark Vitale Date: Wed Dec 11 17:56:47 2013 -0500 viced: remove dead code CheckHost() Remove CheckHost(). Reviewed-on: http://gerrit.openafs.org/10580 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Jeffrey Altman (cherry picked from commit 76076708a921aae0635975d418dea4b06d2c1af6) Change-Id: I7400a874d9d638ed26f30fc46a01ace5857f1300 Reviewed-on: http://gerrit.openafs.org/10602 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Mark Vitale Tested-by: BuildBot commit 36aef3c2b288d41acc7081533ca926ddc896d797 Author: Michael Meffie Date: Wed Oct 2 15:35:09 2013 -0400 cleanup potpourri.h references Clean up references to a header file which was removed some time ago. Reviewed-on: http://gerrit.openafs.org/10318 Tested-by: BuildBot Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear (cherry picked from commit 38fc16ddbf1e5477050db21c94d55f75bdadf80b) Change-Id: Ibb62c0f74b1ea0906d4379c37d2cf8b977d14e16 Reviewed-on: http://gerrit.openafs.org/10473 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit ff6712be60ec81725c4dd3f1f659eb592d4ec5ad Author: Andrew Deason Date: Mon Sep 30 17:51:40 2013 -0500 salvager: Whitespace formatting The whitespace here is pretty weird. Clean it up a little. Reviewed-on: http://gerrit.openafs.org/10311 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 93b0e0d50fb14561ca2b8b0c20876826335ec1ab) Change-Id: I2ee835fb33017301f207d827da10c93bc54bdf4a Reviewed-on: http://gerrit.openafs.org/10768 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 46f6f368a6da15b62beec07bcd3f3f42ca272d94 Author: Simon Wilkinson Date: Fri Feb 15 17:22:02 2013 +0000 vol: Don't assume enum is an int The type that an enum is promoted to for arithmetic is compiler dependent. We can't assume that it's an int, or a short. Explicitly cast the volume state enum where clang gets upset. Reviewed-on: http://gerrit.openafs.org/9137 Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 304fac42b8cd4a71d0df063cafe88b2888e4d175) Change-Id: I8c5b3493549ec88727728a7f28e3430660c673b2 Reviewed-on: http://gerrit.openafs.org/10748 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit dcadd6b5a6f52f1e11235362d0feecd41dfa2ae3 Author: Stephan Wiesand Date: Thu Jan 23 14:43:32 2014 +0100 RedHat: Use systemd unit files on RHEL >= 7 Handle rhel >= 7 like fedora >= 15 when deciding whether to package systemd unit files or sysvinit scripts in the rpm spec file. Reviewed-on: http://gerrit.openafs.org/10631 Tested-by: Stephan Wiesand Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Ken Dreyer (cherry picked from commit 534f802ac900df4704f4e8397eca0aeccf169023) Change-Id: I98f5844b30a6baa85061864f58f64be80f2c7b62 Reviewed-on: http://gerrit.openafs.org/10767 Tested-by: BuildBot Reviewed-by: Ken Dreyer Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 440583f39b3791de9b58a2c9bd3b74aced68c182 Author: Simon Wilkinson Date: Fri Feb 22 10:30:56 2013 +0000 afsmonitor: Allow CBSTATS collection to work The switch which selects the collection number was missing a 'break', so selecting the CBSTATS collection would always fall through to the default, error, case. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9235 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman (cherry picked from commit 75ef02d9dfb43079f111ea22ae351cf0eec13fab) Change-Id: I45bd1152385bdb05d1d027905b52592b1bc0869f Reviewed-on: http://gerrit.openafs.org/10749 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 9feb69bb4c8417f0a8006fd43f6bc15e0b60cefd Author: Simon Wilkinson Date: Fri Mar 30 19:14:38 2012 +0100 libadmin: read returns an ssize_t, not a size_t size_t is unsigned, and therefore can never be less than 0. Using it as a return code from read() means that we never catch read errors. read() is defined as returning ssize_t, so just use this to capture its return code. Caught by clang's new error messages Reviewed-on: http://gerrit.openafs.org/7075 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit b5f75c122875b4212eb1a885d09bfdd63f537a19) Change-Id: Ief5b6cd7751cf68c4254cd113da734c864d53d5d Reviewed-on: http://gerrit.openafs.org/10741 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit d04df5c0e6f9136c400dd49dea3d9aec030e5ca2 Author: Simon Wilkinson Date: Fri Mar 30 19:33:55 2012 +0100 vlserver: unsigned values are always >0 Maxvolidbump is defined as an unisgned int, and thus can never be less than 0. Remove the pointless check, as it just makes clang sad. Reviewed-on: http://gerrit.openafs.org/7084 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 350b5d58779cc127b96497283c2d982e099b911c) Change-Id: Ib902a5b165219469db5f370ebea4c078f10726ee Reviewed-on: http://gerrit.openafs.org/10740 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 22d8f791f66b788011bb3e420ee0dca11e5db188 Author: Derrick Brashear Date: Wed May 1 15:59:41 2013 -0400 pt_util: gcc warning fix it's claimed these are not initialized before use. squelch compiler errors. has to be in parent as otherwise we will zero them in our loop where we potentially want the parent group id, which is not on "this" line as we add members. Reviewed-on: http://gerrit.openafs.org/9840 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 13a3ba7ba2d660a08925a3ccd05d74eedcf8c5cd) Change-Id: I71b968a8ef0751f6e80633e8051fdfb4a17cfd8d Reviewed-on: http://gerrit.openafs.org/10738 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 7af73eb272311f15d357c1d41a1f49a795eb20b8 Author: Benjamin Kaduk Date: Thu Jan 9 23:54:45 2014 -0500 Disable deprecated warnings for krb5 routines In OS X 10.9 Mavericks, Apple has marked all of the krb5 routines as deprecated (in favor of the GSS framework). We must disable these warnings in order to allow the buildslave to have a successful build. Luckily, Apple has left in rope for us to programmatically disable the deprecated attribute with a preprocessor macro. Defining this macro should be safe everywhere, so do so unconditionally. This commit touches a few more files than the version on master does, since the 1.6 branch is using the krb5 library for its rxkad-k5 implementation; the files in auth/ and rxkad/ are specific to 1.6. Reviewed-on: http://gerrit.openafs.org/10699 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 17c50911f79382e3ba8960e4b6c122b348e9baef) Change-Id: Id0e806029e25583698574bf3df626ce12a72312a Reviewed-on: http://gerrit.openafs.org/10735 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 71e3c5d6ca4e1d75504249693fe9f4587c870487 Author: Simon Wilkinson Date: Fri Mar 30 19:40:30 2012 +0100 xdr: Len can never be negative The len parameter to xdr_len is unsigned, so can never be negative. Don't bother testing to see if it is negative, so that clang likes us again. Reviewed-on: http://gerrit.openafs.org/7089 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit f1842bcb87c84e8862ca521f491215e42ce1ee2a) Change-Id: I1cf030b8e9f79bdf867bcaecfd59d8ade7fc8c25 Reviewed-on: http://gerrit.openafs.org/10734 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 2ca29f568956b045f5e3ec27a7dc45683fbd5c67 Author: Simon Wilkinson Date: Fri Mar 30 19:37:36 2012 +0100 rx: Handle negative returns on packet reads rxi_RecvMsg returns an int, because it can return a negative value upon error. Don't store its return value as an unsigned int, because this may hide the potential errors. Modify the error handling loop so that errors get to where they are intended. Reviewed-on: http://gerrit.openafs.org/7087 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 438d6ba63cda7d7484c545a4fd181803e84d68eb) Change-Id: I4f479a4e722b5f298ba2be4e86816ebddede701d Reviewed-on: http://gerrit.openafs.org/10733 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 29a6e95cddff3dab9477937bcd0c64ef2ff00809 Author: Simon Wilkinson Date: Fri Mar 30 19:12:37 2012 +0100 Unix CM: Purge needless brackets Doing if ((a==b)) is unecessary. It's also potentially dangerous, as that's the syntax required to do assignment within an if statement. clang now issues warnings (errors in -Werror mode) when it encounters these. Remove pointless braces from the Unix CM to make clang happy. Reviewed-on: http://gerrit.openafs.org/7074 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 345656ec140f0156f2076629bdfc84940c02160b) Change-Id: I6a47d30fd6ef0ad0c6903c79a0bfe579db527847 Reviewed-on: http://gerrit.openafs.org/10743 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand commit bdb61cc567939386c3685f15ef2ac47bcff8f9ae Author: Simon Wilkinson Date: Fri Mar 30 19:30:18 2012 +0100 vol: Remove unneeded braces Doing if ((a==b)) is unecessary. It's also potentially dangerous, as that's the syntax required to do assignment within an if statement. clang now issues warnings (errors in -Werror mode) when it encounters these. Remove pointless braces from vol to make clang happy. Reviewed-on: http://gerrit.openafs.org/7082 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 58be19d792e6b8e93fbd49bc4ef04bbb8f4560ef) Change-Id: Ie2fd97927eace8a9317598c1b44d2c2610cdc31a Reviewed-on: http://gerrit.openafs.org/10739 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 0bb974222e31a7e7cfea1e2c1b15f542b99dbf99 Author: Simon Wilkinson Date: Fri Mar 30 19:24:23 2012 +0100 ptserver: Remove redundant braces Doing if ((a==b)) is unecessary. It's also potentially dangerous, as that's the syntax required to do assignment within an if statement. clang now issues warnings (errors in -Werror mode) when it encounters these. Remove pointless braces from ptserver to make clang happy. Reviewed-on: http://gerrit.openafs.org/7080 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 4d4e4dde7c0efcf238251b1ea1dc3933810062d0) Change-Id: I4aad6766fc759895c8bffc16dde06169589f64ba Reviewed-on: http://gerrit.openafs.org/10737 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 27f32e81e4fb8bf7219d732fc9bb053234ba4290 Author: Simon Wilkinson Date: Fri Mar 30 19:39:51 2012 +0100 rx: Remove needless braces Doing if ((a==b)) is unecessary. It's also potentially dangerous, as that's the syntax required to do assignment within an if statement. clang now issues warnings (errors in -Werror mode) when it encounters these. Remove pointless braces from the Unix CM to make clang happy. Reviewed-on: http://gerrit.openafs.org/7088 Tested-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 5e107724f3661254cfdb693ae2d4d1c5238eba7d) Change-Id: I99a04d9a2c547e34a3daca6f9e6714f6c7b76b9c Reviewed-on: http://gerrit.openafs.org/10732 Tested-by: BuildBot Reviewed-by: Perry Ruiter Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand commit 642e7f586de57683aadbc59545ebb5607afc90c6 Author: Arne Wiebalck Date: Fri Dec 13 11:46:04 2013 +0100 make openafs uninstallable even if /afs is missing The preuninstall scriptlet of the openafs RPM removes /afs. If, for whatever reason, that directory does not exist, the scriptlet will fail and hence break the deinstallation of the openafs package. The proposed patch makes the scriptlet evaluate to true even if the /afs has been removed by some other means and allows the package to be uninstalled. Reviewed-on: http://gerrit.openafs.org/10581 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 0c5d403076946c7a4f53f5e44df8fe0d986cea06) Change-Id: Ie686545c6618242f2c2644a01891cd0dfe0d0d05 Reviewed-on: http://gerrit.openafs.org/10600 Reviewed-by: Ken Dreyer Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 6385d88318e47953f1ebbf2ff60246259e1720b2 Author: Michael Meffie Date: Wed Jan 22 20:23:29 2014 -0500 doc: fix typo in fs setacl Fix typo in the dropbox section where 'l' was referred to as 'read', not 'lookup'. Reviewed-on: http://gerrit.openafs.org/10750 Tested-by: BuildBot Reviewed-by: Ken Dreyer (cherry picked from commit eb3f8c99edcf005dfba836ae9ab1d3102f162c2a) Change-Id: I177e6975c19d176e5a7277d0b458e36b4e5f99f9 Reviewed-on: http://gerrit.openafs.org/10751 Tested-by: BuildBot Reviewed-by: Ken Dreyer Reviewed-by: Stephan Wiesand